Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Model Name Scanning #965

Merged
merged 36 commits into from
Oct 3, 2023
Merged

Introduce Model Name Scanning #965

merged 36 commits into from
Oct 3, 2023

Conversation

neotheprogramist
Copy link
Collaborator

Mateusz Zając and others added 30 commits October 3, 2023 07:56
reenabled index and added interface with keys
41942cb
getting by key
83ed6f6
bidirectional reference for keys and debug
6ff7a9b
changed panic to assert
fe6191d
commented out test
2a8baab
a placeholder for key deletion
a76b990
using index in database
8df343d
using new api in world
60dcf56
increased gas budget for failing tests
7b60981
simple test entities in world
2039dd9
@neotheprogramist
fix tests
94f042d
@neotheprogramist
delete .vscode
8f631e9
@neotheprogramist
add .vscode to .gitignore
ba47ffd
@neotheprogramist
disable indexing by default
5eafbae
@neotheprogramist
fix tests
af8781e
@matzayonc
doc comments
8f87c55
@verzotokumpel
added new test cases
525335b
@verzotokumpel
improved some tests
9dca483
@matzayonc
updating indexer to use layouts
4f3b9ae
@neotheprogramist
run with CAIRO_FIX_TESTS=1
b9d704a
@neotheprogramist
clippy
5604bf1
@matzayonc
updated test_entities for new api
8a73c21
@matzayonc
rebase and comments
1ae23a2
@matzayonc @tarrencev
Update crates/dojo-core/src/database/index.cairo
e0581c7 
Co-authored-by: Tarrence van As <[email protected]>
@matzayonc
ci trigger
9091d4a
@neotheprogramist
CAIRO_FIX_TESTS=1
c0b60c2
@tarrencev
Remove partitions
d24f6cc
@tarrencev
Propose api
ccb83cb
made future interface compile
4173a06
enabled adding to index and simple test
5ff7ae5
@tarrencev tarrencev merged commit 1135041 into dojoengine:main Oct 3, 2023
9 checks passed
@neotheprogramist neotheprogramist deleted the 8-index-by-name branch October 4, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrencev tarrencev Awaiting requested review from tarrencev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Model Name Scanning in Line with Current Proposal
4 participants
@neotheprogramist @tarrencev @matzayonc @verzotokumpel